BabylonJS / Babylon.js

Babylon.js is a powerful, beautiful, simple, and open game and rendering engine packed into a friendly JavaScript framework.
http://www.babylonjs.com
Apache License 2.0
23.06k stars 3.41k forks source link

boundingBoxGizmo dragging is buggy since v7.21.0 #15485

Closed kai-dorschner-twinsity closed 3 weeks ago

kai-dorschner-twinsity commented 3 weeks ago

Repro

Also, some of the gizmos have a wrong orientation, see the following screenshot: image

Desktop (please complete the following information):

Additional Context The styling of gizmos has changed in https://github.com/BabylonJS/Babylon.js/releases/tag/7.21.0. See https://github.com/BabylonJS/Babylon.js/pull/15415 for reference.

CedricGuillemet commented 3 weeks ago

https://github.com/BabylonJS/Babylon.js/pull/15487 Thanks for testing snapshots when they are available @kai-dorschner-twinsity

kai-dorschner-twinsity commented 3 weeks ago

Thank you guys for being this quick in solving issues 💯

kai-dorschner-twinsity commented 3 weeks ago

Hey guys! There might've been an oversight regarding the issue. Title title said that the dragging itself is buggy, and, as a side node the handles are also twisted. As far as I can see only the twisted handles have been fixed, but not the dragging itself. See playground to verify. To be more precise:

This goes on for many, but not all handles, here's a (maybe incomplete) list of broken and correct handles (RED: broken, GREEN: correct): image

CedricGuillemet commented 3 weeks ago

I'm taking a look.

CedricGuillemet commented 3 weeks ago

I did 2 passes of testing https://github.com/BabylonJS/Babylon.js/pull/15503 thanks for doing checks on your side @kai-dorschner-twinsity :)