search

BabylonJS / BabylonNative

Build cross-platform native applications with the power of the Babylon.js JavaScript framework
MIT License
757 stars 131 forks source link

Error when building for Win32 using V8 #1256

Closed alexchuber closed 1 year ago

alexchuber commented 1 year ago 
CMake Error at build/win32/_deps/jsruntimehost-src/Core/Node-API/CMakeLists.txt:98 (message):
  Unsupported JavaScript engine: V8
bghgary commented 1 year ago

@CedricGuillemet I didn't add V8 support for Windows in JsRuntimeHost, so when we integrated it over, V8 support disappeared.

CedricGuillemet commented 1 year ago

self assigning, I can add that support at the same time as CMake install PR.

CedricGuillemet commented 1 year ago

https://github.com/BabylonJS/JsRuntimeHost/pull/41

bghgary commented 1 year ago

The JsRuntimeHost integration has been reverted, so this should work again.