search

BabylonJS / BabylonNative

Build cross-platform native applications with the power of the Babylon.js JavaScript framework
MIT License
757 stars 131 forks source link

CMake npm install function ignores package.lock file in Apps folder #1257

Closed alexchuber closed 1 year ago

alexchuber commented 1 year ago

If you run cmake at the time of writing, it will pull 6.11.2. But, if you run npm install, it will use 6.4.1.

bghgary commented 1 year ago

@CedricGuillemet This is because we are ignoring the lock file in the npm install function.

CedricGuillemet commented 1 year ago

Yes, it's explicit in the command line to not use the package lock. Does it make sense to remove package lock in the repo?

ryantrem commented 1 year ago

Why not use the package lock file? Usually this is kind of an anti pattern since build behavior can change without making any changes to any files in the repo.

bghgary commented 1 year ago

We should use the package lock file here. I added the ignoring of lock files for a different purpose for JsRuntimeHost.

CedricGuillemet commented 1 year ago

Fixed with https://github.com/BabylonJS/BabylonNative/pull/1260

CedricGuillemet commented 1 year ago

Fixed with https://github.com/BabylonJS/BabylonNative/pull/1263 . closing.