Establish and adhere to CMake platforms pattern

BabylonJS / BabylonNative

Build cross-platform native applications with the power of the Babylon.js JavaScript framework

MIT License

774 stars 133 forks source link

Establish and adhere to CMake platforms pattern #55

Closed syntheticmagus closed 4 years ago

syntheticmagus commented 5 years ago

We currently have a mixture of patterns for checking platforms throughout our CMakeLists.txt files, mixing variables like WINDOWS_STORE and APPLE in with our usage of BABYLON_NATIVE_PLATFORM. Let's discuss (here in this issue?) what the preferred pattern should be, then propagate pattern everywhere that makes sense and, if there are exceptions where the pattern should be broken, clearly designate these exceptions with comments.

CedricGuillemet commented 5 years ago

defined :

ANDROID
APPLE
- IOS
- TVOS
- WATCHOS
WINDOWS
- UWP

IOS,TVOS,WATCHOS defined by the ios-cmake toolchain ANDROID, APPLE,WINDOWS defined automatically UWP is the only one specified by BABYLON_NATIVE_PLATFORM.

CedricGuillemet commented 5 years ago

https://github.com/BabylonJS/BabylonNative/pull/80

CedricGuillemet commented 4 years ago

PR merged. Can I close it? @syntheticmagus

bghgary commented 4 years ago

Yes, this can be closed.