search

BabylonJS / BabylonReactNative

Build React Native applications with the power of Babylon Native
MIT License
362 stars 57 forks source link

VisualStudio 2022 support #358

Open CedricGuillemet opened 2 years ago

CedricGuillemet commented 2 years ago

I did a quick test (unfortunate) building BRN with VS2022 and got compilation error 

E:\dev\babylon\BRNDeploy064\Apps\Playground\Playground\node_modules\react-native-windows\Mso\dispatchQueue\dispatchQueue.h(728,17): error C2607: static assertion failed
       [E:\dev\babylon\BRNDeploy064\Apps\Playground\Playground\node_modules\react-native-windows\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]

I don't know if it's related to VS, Windows SDK or something else. Anyway, a test with newest VS might be a good idea.

bghgary commented 2 years ago

I'm not sure this belongs in BabylonReactNative repo. We already know VS2022 doesn't work in BabylonNative repo. Not sure there is an issue on it though. (it works now)

CedricGuillemet commented 2 years ago

Problems won't be the same because of dependencies (react native windows and other packages). It won't be as hard/ time consuming with BN.

EDIT: The problem is not the same between BN and BRN. for BN, it's a cmake/gradle problem. Here, it's a Windows SDK/CPP version issue.

CedricGuillemet commented 1 year ago

When trying the playground build/test githubaction with VS2022, I got this error:

D:\a\BabylonReactNative-1\BabylonReactNative-1\Playground\node_modules\react-native-windows\Microsoft.ReactNative\Utils\Helpers.h(21,8): error C2187: syntax error: 'typename' was unexpected here (compiling source file Modules\LogBoxModule.cpp) [D:\a\BabylonReactNative-1\BabylonReactNative-1\Playground\node_modules\react-native-windows\Microsoft.ReactNative\Microsoft.ReactNative.vcxproj]

It's fine with VS2019