search

BabylonJS / BabylonReactNative

Build React Native applications with the power of Babylon Native
MIT License
382 stars 61 forks source link

Windows SDK version used for building packages #507

Open CedricGuillemet opened 1 year ago

CedricGuillemet commented 1 year ago

Latest Windows SDK version seems to be used for Windows package build and release. This forces user to use the latest version as well. A variable in the build should be available to set it to a version compatible for most users.

CedricGuillemet commented 1 year ago

I'm taking a look

CedricGuillemet commented 4 months ago

More context: All projects using c++ code need to use the same cppwinrt version. Otherwise, linking erros will popup. For example, RNPermissions was not using the cppwinrt version used for RNW until this PR : https://github.com/zoontek/react-native-permissions/pull/860/files BRN RNTA build is more explicit https://github.com/BabylonJS/BabylonReactNative/blob/3ab10059b8bdd4e5262136865565db0968c11e34/.github/workflows/pr.yml#L259 But next RNW version might change that number and if a user project is using a different version, then nothing will work. One solution might be to package a .dll of BRN instead. This way, PDB might be packaged as well.