BabylonJS / BabylonReactNative

Build React Native applications with the power of Babylon Native
MIT License
380 stars 61 forks source link

BabylonNative.h is missing in @babylonjs/react-native v1.7.7 and 1.7.8. #620

Closed WayneKim92 closed 11 months ago

WayneKim92 commented 11 months ago

Describe the bug BabylonNative.h is missing in @babylonjs/react-native v1.7.7 and 1.7.8. Due to this issue, when building an iOS app, a build error occurs saying that BabylonNative.h cannot be found.

To Reproduce

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Other

chenkuangkuang commented 11 months ago

Same issue. Anyone help?

chenkuangkuang commented 11 months ago

I found that you can replace "Babylonnative.h" with "../../react-native/shared/babylonNative.h".which is wroted in ""@babylonjs/react-native-iosandroid-0-69" @WayneKim92

WayneKim92 commented 11 months ago

thanks. I will refer to this when upgrading the version. I am using version 1.7.5 and have no plans to upload it right away.

bghgary commented 11 months ago

@CedricGuillemet FYI

WayneKim92 commented 11 months ago

@chenkuangkuang thank you. It works for me. But as far as a build.

image

WayneKim92 commented 11 months ago

ummmmm... Build and run was successful, but an execution error occurred. lol~

image

CedricGuillemet commented 11 months ago

I believe this issue has been introduced with https://github.com/BabylonJS/BabylonReactNative/pull/616 I'm taking a closer look.

chenkuangkuang commented 11 months ago

@CedricGuillemet can you help this https://github.com/BabylonJS/BabylonReactNative/issues/620#issuecomment-1829046809?

chenkuangkuang commented 11 months ago

@WayneKim92 the same as me ...

CedricGuillemet commented 11 months ago

@CedricGuillemet can you help this #620 (comment)?

Let me first fix the package, then I'll try to repro the crash.

chenkuangkuang commented 11 months ago

@CedricGuillemet thanks a lot.This is the versions I use:

"@babylonjs/core": "^6.31.0",
"@babylonjs/loaders": "^6.31.0",
"@babylonjs/react-native": "^1.7.8",
"@babylonjs/react-native-iosandroid-0-71": "^1.7.8",
"react-native": "0.71.14",
CedricGuillemet commented 11 months ago

I've fixed the issue with package 1.8.0 and now I can repro #622 Closing.