BabylonJS / BabylonToolkit

Home of the community maintained Unity & Unreal exporters for Babylon.js
180 stars 47 forks source link

Replace .unitypackage with a proper UPM package #71

Closed andybak closed 2 months ago

andybak commented 8 months ago

I was a bit surprised to find .unitypackages uploaded directly to the repo. Usually the source goes in the repo and the .unitypackages are uploaded to Releases.

In any case - UPM is the modern way to handle things. Happy to work on a PR if it's likely to be accepted.

andybak commented 8 months ago

I've just looked at this a bit more closely - the only Unity code is in a Legacy folder and it's using Siccity's GLTF code. Is this the plan going forward? Unity has "blessed" GLTFast for import and UnityGLTF has recently had a huge update.

Would they be a better starting points?

MackeyK24 commented 5 months ago

Yo @andybak ... If you can build this from the .unity packages... That would be awesome :)

MackeyK24 commented 2 months ago

Babylon Toolkit is not published as Unity Package Manager install.

In Unity's Package Manager: Click the "+" button ➔ Add package from git URL....

Community Edition

https://github.com/codewrxai/CommunityEdition.git

Professional Edition

https://github.com/codewrxai/ProfessionalEdition.git
andybak commented 2 months ago

Just to clarify for others - as I originally misread their comment.

They have forked and repackaged Babylon as a UPM package - which is fantastic.

@MackeyK24 - any idea if this will get merged back in to the official repo? It's a big improvement.

MackeyK24 commented 2 months ago

The previous version was hard coded to work from the Assets/[Babylon] folder. I dont see they could have gotten it to fully work as a UPM.

But now I natively support UPM

Git Installation In Unity's Package Manager

Click "+" Button ➔ Add package from git url....

Community Edition

https://github.com/babylontoolkit/communityedition.git Professional Edition

https://github.com/babylontoolkit/professionaledition.git Local Installation In Unity's Package Manager

Click "+" Button ➔ Add package from tarball....

Community Edition

https://github.com/babylontoolkit/communityedition/releases Professional Edition

https://github.com/babylontoolkit/professionaledition/releases

MackeyK24 commented 2 months ago

Done