search

BabylonJS / Documentation

Babylon.js's documentation website
https://doc.babylonjs.com
Apache License 2.0
77 stars 231 forks source link

Updates to GUI docs to include HtmlMesh as another GUI option #1095

Closed ericwood73 closed 4 months ago

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 6, 2024 11:27am
ericwood73 commented 5 months ago

Is there a link for the resource? Somewhere to read about HtmlMesh? does it already exist in the page?

I could add a link to the GitHub readme for HtmlMesh.

ericwood73 commented 5 months ago

Or I could add a page for HtmlMesh to community extensions. That would probably be better.

RaananW commented 5 months ago

Whatever you find better. Would be great to add a page for it, but if it is too much, a link to the repo would be great

deltakosh commented 4 months ago

up:)

RaananW commented 4 months ago

@ericwood73 - we want to merge this, have you made the adjustments? Thanks :-)

ericwood73 commented 4 months ago

No. Sorry. Will work on it today.

ericwood73 commented 4 months ago

@RaananW I completed my updates. Ready for review.

RaananW commented 4 months ago

You should add it to structure.json as well, as we don't take the directory structure as is. You can run npm run build:local (or yarn, of course), to make sure it compiles correctly.

ericwood73 commented 4 months ago

Copy. I was editing in github, but I'll pull down and run the build.

ericwood73 commented 4 months ago

@RaananW How do I get the error when building locally. It just tells me it failed to build the extensions page, but it doesn't say why. I added the page to structure.json and the build error on gui went away (or it's now hitting a different error because now it is looking at the extensions page).

RaananW commented 4 months ago

@RaananW How do I get the error when building locally. It just tells me it failed to build the extensions page, but it doesn't say why. I added the page to structure.json and the build error on gui went away (or it's now hitting a different error because now it is looking at the extensions page).

The build will provide you with a reason. Might be an internal link missing. Which probably your link to the document from the page it is complaining about is incorrect

ericwood73 commented 4 months ago

It doesn't give me any reason why it fails. Just Error: Export encountered errors on following paths: /[...id]: /communityExtensions/htmlMesh. I'll keep eliminating external references one by one until I find the one it is choking on.

RaananW commented 4 months ago

Have you pushed the structure.json update? i'm pulling the branch now

RaananW commented 4 months ago

Made a few changes to the PR (I hope I didn't push myself too much here...)

The way it is right now works as expected :-) I'll merge it once it is done building

ericwood73 commented 4 months ago

Thanks. I made the changes to structure and for some reason it wasn't building locally but I pulled your changes and now it works.