search

BabylonJS / Documentation

Babylon.js's documentation website
https://doc.babylonjs.com
Apache License 2.0
76 stars 233 forks source link

feature: refactor get the snippet code #1120

Closed NguyenTuanCanh closed 3 weeks ago

NguyenTuanCanh commented 2 months ago

Changes made:

  1. Removed unnecessary nested promises by chaining then() calls.
  2. Used forEach loop instead of for loop for iterating over codeLines.
  3. Replaced indexOf with includes for checking if a line contains the search term.
  4. Simplified the logic for setting startingLine and foundLine within the loop.
  5. Replaced arrow functions with concise arrow functions where possible.
vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 5, 2024 9:57am
RaananW commented 2 months ago

This is mainly a cosmetic change, right? No functionality has changed?

RaananW commented 2 months ago

I am a bit confused as to the current changes. Formatting has changed a bit, but it seems like the code as it is is almost (or even completely) the same?

RaananW commented 1 month ago

any update here? or should I close it?