Editor with language choice

BabylonJS / Editor

Community managed visual editor for Babylon.js

http://editor.babylonjs.com/

813 stars 232 forks source link

Editor with language choice #137

Open dad72 opened 4 years ago

dad72 commented 4 years ago

Hi Julien,

It would be nice to be able to put the editor in another language (In French).

The idea is to make a separate file that stores all the texts. So to add other languages, it would be enough to edit this file (Json for example) to give it a name of the country (French.lang.js, English.lang.js ...) The editor would load to automatically list all the existing language files. Then in the editor menu select the desired language from those available.

What do you think of this idea ?

julien-moreau commented 4 years ago

Hey! Sure it is an excellent idea. This is already asked here: https://github.com/BabylonJS/Editor/issues/128

I’m keeping this issue opened and will close the other as this one is more complete :)

Will start on it once thé 3.1.2 is released :)

dad72 commented 4 years ago

I did not pay attention that this had already been asked. I have been to see and see that this has resulted in the creation of clear and dark theme. The dark theme is really pretty. The editor has evolved since the beginning when I saw it. Good luck Julien and great job, I am impressed by all that has been done and I know all the work that represents an editor.

coldestheart commented 4 years ago

Oh! when it happens a can help translate it to Russian

julien-moreau commented 3 years ago

@dad72 are you interested to contribute to it ? Using i18next would do well the job :)

dad72 commented 3 years ago

I don't know if I'm going to have a lot of time to get it done in a reasonable amount of time. what i18next is ?

dad72 commented 3 years ago

I did research on i18next to find out what it is. Sounds good, but have never learned to use it.

My ways I did it on my projects :

A json file containing the languages -- "Menu": { "file": { "createProjet" : "Créer un projet", }} -- I then replace in the editor all the key words. Menu.file.createProjet
A GUI submenu which lists the available languages (generally used PHP which is more direct)
I saved the user's choice of language in a cookies either in JS or in PHP
When the user chooses a language, I reloaded the editor.

julien-moreau commented 3 years ago

Excellent, excactly what I though Using i18next allows to manage plural, data merging etc.

So instead of myText = menu.file.createProject it would be i18n.t("menu.file.createProject")

Will do that once the basics of the editor are done and stable then :)

dad72 commented 3 years ago

If you put the basics in the editor by making the English Json file, I could help to make the file in French eventually. Unfortunately, I don't have a lot of knowledge about the architecture of your editor in its sources. But i would gladly help later