BabylonJS / Editor

Community managed visual editor for Babylon.js
http://editor.babylonjs.com/
813 stars 232 forks source link

The editor Scenes and the post-play Scenes are completely different #286

Closed KitStarLee closed 2 years ago

KitStarLee commented 2 years ago

Very urgent, it seems to be a clear coat problem

image image

KitStarLee commented 2 years ago

Very urgent, work cannot continue @julien-moreau 。Hope to get your help, thank you very much

julien-moreau commented 2 years ago

Hi @KitStarLee I reproduced! It looks like PBR material is not the same once serialized (when project is being saved). I'm checking the problem and come with a solution ASAP

KitStarLee commented 2 years ago

@julien-moreau Thank you for your attention

julien-moreau commented 2 years ago

Hi @KitStarLee

Can you try playing with the Metallic F0 Factor property of your materials in the inspector? It looks like this parameter is applied differently before and after serialization.

marcobertagna commented 2 years ago

I have the same problem. I've try to set Metallic F0 Factor, it improves, but anyway there are differences. Could it be a gamma issue?

julien-moreau commented 2 years ago

Hi !

I finally reproduced the bug in the Babylon.JS Playground. The bug has been reported here: https://forum.babylonjs.com/t/problem-when-parsing-pbr-and-environment-textures/21845 Once fixed, the editor will be released with that fix (probably 4.0.2)

marcobertagna commented 2 years ago

Great! Thanks!

julien-moreau commented 2 years ago

Deployed! You can update the editor to the version 4.0.2 (here: http://editor.babylonjs.com/) or use the notification available in the editor to download the latest version.

To fix the problem, simply open the project and re-save. Please let me know if that works for you :)

marcobertagna commented 2 years ago

Fantastic news! I try it soon!

marcobertagna commented 2 years ago

@julien-moreau I try the version 4.0.2. the fix works! I notify you that the fix works on new projects, while on those created previously, it keeps having the same error. This is not a problem for me, but I'm saying it for your information.

julien-moreau commented 2 years ago

Thanks for that feedback @marcobertagna ! Don't hesitate if you have any other feedback :)