BabylonJS / Editor

Community managed visual editor for Babylon.js
http://editor.babylonjs.com/
813 stars 232 forks source link

VScale parameter reversed #33

Closed vortice3D closed 6 years ago

vortice3D commented 6 years ago

Hi Julian:

Please note that all textures appear wrong when applied because they have the VScale parameter reversed. One has to set it to -1 in order to see the textures correctly.

If scene is saved and reopened, the textures are reversed again. But putting the textures in first place without changing anything, saving the scene and reopening it, will display the texture correctly.

Best regards.

julien-moreau commented 6 years ago

Will fix that, thanks for reporting :)

vortice3D commented 6 years ago

Thanks to you, Julien.

julien-moreau commented 6 years ago

I cannot reproduce, maybe I'm trying at the wrong way. Are you exporting the editor project to reopen it (.editorproject)? Or the Babylon.js final scene (.babylon)?

vortice3D commented 6 years ago

Dear Julien:

Ok, let me talk to my colleage in charge of CGs, tomorrow in the morning(CET), as he's the one who told me about this weird behavior.

Best regards.

julien-moreau commented 6 years ago

Thanks! Then will try to fix tomorrow :)

vortice3D commented 6 years ago

Hi there, joie here. I don't know what you mean by "editorproject", I can't see where I can save an editor project. The issue with the VScale happens with every 3D model we try with. Although the issue is very strange because it seems to be just a visualization problem because, if I don't touch the VScale and just reopen the scene, the texture is fine.

vortice3D commented 6 years ago

Hi Julien:

After the last message (sent by my coworker Joie), if you still can´t reproduce the problem; I think we can test the behavior in another computer.

Please, let us know.

Best regards.

julien-moreau commented 6 years ago

@vortice3D I unfortunately cannot reproduce, I tried to add my own texture and modify vScale. The render was the expected. I also exported the scene and reopened it: the parameter is well applied

I'm not sure to understand the process to reproduce :(

After export and before export:

capture d ecran 2017-11-30 a 20 03 20 capture d ecran 2017-11-30 a 20 03 49
vortice3D commented 6 years ago

Hi Julien:

First of all let us thank you for the several improvements you're doing in the editor.

About the VScale problem, please download a screen video capture from this wetransfer link.

Please note:

We think that it has first a visualization problem (with the correct data) that forces the user to think they are wrong, and so changing the data, what takes us to the beginning.

We have tested it on MS Windows platforms, FF (v57.0 64bit) and Chrome (v62.0.320.94 64bit).

Best regards.

julien-moreau commented 6 years ago

Ok I see the bug now! I reproduced with the GLTF loader My question: are you importing .gltf (or .glb) files or .babylon files? Or another format?

For the scale factor and all other configurations, they are available in the editor project (.editorproject). More informations here: https://medium.com/babylon-js/welcome-to-the-babylon-js-editor-c08dccdcec07 at the section "Saving your project"

By "environment", you mean the scene default environment texture used by all PBR materials?

vortice3D commented 6 years ago

Ok Julien:

We are working with the .babylon files generated by your BJS Editor.

About "environment" we mean the one used by the PBR, but once you mention it, what is the way to update/change the other one (cubemap or so)?

Best regards.

julien-moreau commented 6 years ago

After checking, I cannot reproduce the vscale :( For the environment texture, I found that it is not serialized in the final .babylon scene. So I'm updating Babylon.js to serialize the environement texture :)

julien-moreau commented 6 years ago

I don't know if that's possible but can you share the scene you are using so I can reproduce the bug and check why it is not working as expected ?

vortice3D commented 6 years ago

Ok Julien:

We are working right now in order to be able to share a scene.

I'll keep in touch with you soon.

julien-moreau commented 6 years ago

Thank you very much !

julien-moreau commented 6 years ago

@vortice3D Any news ? :)

vortice3D commented 6 years ago

Hi Julien:

At the moment we can´t reproduce the issue on a clean basic scene.

Let us investigate a little more, but it seems to have to do with something in our scene or geometry.

I'll come back to you as soon as we have news.

Best regards.

julien-moreau commented 6 years ago

@vortice3D can you test this version (which is the V2) http://editor.babylonjs.com/v2/ And tell me if you still reproduce ? :) Thanks!