BabylonJS / Editor

Community managed visual editor for Babylon.js
http://editor.babylonjs.com/
816 stars 232 forks source link

Scripts launched by VLC?? #330

Closed ernest4 closed 2 years ago

ernest4 commented 2 years ago

Nice work on the project!

OS: mac

This is weird but for some reason opening scripts from the editor for editing keeps using VLC media player instead of VSCode.

When I check the project files it assumes the .ts files are VLC by default, quite bizarre.

Screenshot 2021-12-01 at 08 41 14

I can't seem to find a way to set it so all of those files can be opened with VSCode either. I can set it one file at a time only haha.

This looks like issue with Mac file system treating these files like this, not specific to Babylon editor (heres another random folder with typescript files).

Screenshot 2021-12-01 at 08 53 09

So technically I suppose it's end users (Mac) problem, but it is quite disorienting having to deal this for the first time ever. Normally you're in VSCode by default so all the files get interpreted properly.

That said is there no way to force the Editor to default try open the .ts files with VSCode and only when VSCode is not present on the system, default to something else? (sorry, I've no experience with electron haha, or desktop app dev for that matter haha)

RaananW commented 2 years ago

That's an OS file extension association. This will happen with any .ts file you have, not only the editor's generated files.

You should follow this - https://www.macrumors.com/how-to/how-to-manage-file-associations-in-macos/ , and make sure .ts files are loaded using vscode.

If you want to open an entire directory, use vscode's "open" option and select the folder.

Regarding this:

That said is there no way to force the Editor to default try open the .ts files with VSCode and only when VSCode is not present on the system, default to something else? (sorry, I've no experience with electron haha, or desktop app dev for that matter haha)

I'll let @julien-moreau answer :-)

julien-moreau commented 2 years ago

Hi @ernest4 ! I was searching for an answer and realized @RaananW already answered! The link RaananW shared works perfectly (like this one, even old: https://apple.stackexchange.com/questions/780/problem-with-always-open-with-in-os-x). Associating files depends on the OS and should be configured on the OS itself.

I agree that the Editor can force using VSCode. Unfortunately, even if the editor is optimized to work with VSCode (shortcuts to open the project in VSCode, remote debug support, etc.), it should let the user choose which code editor to use to open TS files. For example, there are still a lot of developers preferring Atom than VSCode

Let me know if following the tutorial RaananW shared works and I'll close the issue :)

ernest4 commented 2 years ago

Hey thanks guys! Changed it at OS level, all good now :)

Yeah defaulting to VSCode open was bit of a stretch there :P Thanks!

julien-moreau commented 2 years ago

Perfect ! I'm closing the issue and I'll add some documentation about it :)