search

BabylonJS / Editor

Community managed visual editor for Babylon.js
http://editor.babylonjs.com/
813 stars 232 forks source link

The source Editor cannot be built in Node v17 #366

Open eherozhao opened 2 years ago

eherozhao commented 2 years ago

My node was v17 in the past and it failed to built the Editor source code. After installing to v16, I can build the Editor from scratch. Do we have any documentation related to the requirement of the Editor like supported Node version?

julien-moreau commented 2 years ago

Hi @eherozhao ! I just reproduced and I'm trying to find a fix for that. Node.JS 17 should be supported

eherozhao commented 2 years ago

I noticed the Editor was updated to newer version. Is this issue solved? If it is, please feel free to close this issue.

julien-moreau commented 2 years ago

Hi @eherozhao ! Unfortunately not and it looks like the problem comes from the module node-pty which uses deprecated Node.JS C++ Api. I'm still digging. Do you confirm that you can't use Node.JS 16 ?

eherozhao commented 2 years ago

I can definitely use Node 16 and it was what I used to fix the problem. I don't think we need an urgent fix for Node 17. Thank you for your help.