Resolves Issue with MacOS when loading ide

BabylonJS / Editor

Community managed visual editor for Babylon.js

http://editor.babylonjs.com/

812 stars 232 forks source link

Resolves Issue with MacOS when loading ide #432

Open seacloud9 opened 12 months ago

seacloud9 commented 12 months ago

Issue this update resolves here

After the result, it look like this:

https://github.com/BabylonJS/Editor/assets/640305/c5d0800e-96be-4019-98bd-e73436371c10

resolves macOS errors by enabling the tools wait and reverting a recent change to preload/editor that negatively impacts macOS

julien-moreau commented 11 months ago

Hey @seacloud9 !

This is annoying on my side because I don't reproduce on my macOS. Are you using an arm64 build or a x64 one ?

The problem here is that editorExports.editor = (window as any).editor; is mandatory for JS scripts executable in assets and require('../renderer/module.js'); as well to run projects inside the editor :(

seacloud9 commented 11 months ago

Hello @julien-moreau,

I agree. I noticed that the code was much cleaner with those changes in, but I had to rewind the commits to find where MacOS stopped working. I will spend some time today to see if I can not investigate a better fix rather than a revert.

I am using M1/arm64. This is an excellent project! Thanks for sharing.