search

BabylonJS / Exporters

Exporters for Babylon.js and gltf file formats
Other
613 stars 313 forks source link

3ds max 2025 support #1121

Closed FrogsInSpace closed 4 weeks ago

FrogsInSpace commented 1 month ago

adds support for 3ds Max 2025 including new menumanager API support ( plus menu refresh workarrounds )

SergioRZMasson commented 1 month ago

I will take a look, should be done reviewing it today.

SergioRZMasson commented 1 month ago

I'm fine with the PR in general, the only issue is that you Visual Studio is probably replacing spaces with tabs, this can make indentation look wrong depending on which editor you use (it looks wrong on Github for example). The standard for this repo is to use spaces.

FrogsInSpace commented 1 month ago

Thanks, i'll fix the tabs of course i assumed this to be configured via attributes ...

SergioRZMasson commented 1 month ago

Thanks, i'll fix the tabs of course i assumed this to be configured via attributes ...

In visual studio go to: Tools->Options->Text Editor->All Languages->Tabs

Change Tab to use "Insert Spaces" instead of "Keep Tabs".

SergioRZMasson commented 1 month ago

Thanks, i'll fix the tabs of course i assumed this to be configured via attributes ...

Sorry, I thought you were asking how to do it in Visual Studio. I'm not sure this can be configured via attributes, though...

FrogsInSpace commented 1 month ago

Sorry, I thought you were asking how to do it in Visual Studio. I'm not sure this can be configured via attributes, though...

no prob, AFAIK it can be done via attributes or even better via .editorconfig

I usually work with a multitude of projects from a a broad range of tech stacks and conventions. so changing the Visual Studio tab settings itself would be not feasable

I'll create a local .editorconfig, and maybe even create a PR for it later ...

FrogsInSpace commented 1 month ago

Tabs have been converted back to spaces I noticed the existing formating style mix of "if(..." and "if (..." was unified to "if (..." in the files i touched ( most likely by the untabify extension i used ). IMHO thats an improvement in any case at least ...

FrogsInSpace commented 4 weeks ago

Thanks for merging, seems the pipeline did'nt build or include the 3dsMax 2025 build in the release assets. Installer says it can't find the Max_2025.zip either So i guess this has to be something done somewhere in the CI/CD scripts

SergioRZMasson commented 4 weeks ago

Yep, you are right. I will take a look at the CI.

den-dc commented 4 weeks ago

please i reaaly need 2025 support )

SergioRZMasson commented 4 weeks ago

Done! Can you guys give it a try?

FrogsInSpace commented 4 weeks ago

Installer seems to be working, download the zip and installing but for me the Max 2025 assembly version does'nt load into Max. Not sure about the reason currently.

There is the UiViewmodell.dll included in the Max_2025.zip package which shouldn't be in there ( its a 3ds Max binary ). This is due to ref setting copy option not being set correctrly in the project settings. This should fix it

https://github.com/FrogsInSpace/babylonjs-Exporters/commit/0065160d510e00a5a5a7576f7c6418e30357a3eb

FrogsInSpace commented 4 weeks ago

Okay: appears that the tabs to space commit broke the Babylon menu registration process in the 3ds Max 2025 build ( #tabs to space

not sure what it is , but will have a look at it tomorrow ( its already late here :) )

SergioRZMasson commented 4 weeks ago

I'm doing a quick PR to fix the unnecessary copy of 3DS Max binaries

FrogsInSpace commented 4 weeks ago

I got thre reason for the failing menu creation: For some reason the changed files in the tabs-to-spaces commit are UTF8-BOM encoded, and running the embedded maxscript fails because of that, i can fix that tomorrow

Update: got that bugger, faulty entry in .editorconfig which caused the UTF8-BOM encoding