search

BabylonJS / Extensions

Extensions for Babylon.js
177 stars 157 forks source link

Adding GIF Exporting Feature #140

Closed antpowell closed 6 years ago

antpowell commented 6 years ago

Allow for recording of a Scene and exporting that recording as a GIF to the local machine.

deltakosh commented 6 years ago

Once merged, you will need to provide documentation on doc.babylonjs.com/extensions :)

Thanks a lot Anthony!

antpowell commented 6 years ago

Rgr that, will do.

antpowell commented 6 years ago

Will check that out right away.

antpowell commented 6 years ago

I believe I found and removed the files let me know if anything else looks fishy

deltakosh commented 6 years ago

I think dist should also contains the final file

deltakosh commented 6 years ago

Still no .js in dist, is it expected?

antpowell commented 6 years ago

I just found out why, the global .gitignore has .js and .map so all my commits where basically doing nothing, lol. should I remove that and rebuild?

deltakosh commented 6 years ago

You can manually add the specific files you need

deltakosh commented 6 years ago

Wonderful :D

deltakosh commented 6 years ago

Now we need a beautiful doc and we can start socializing your great work!

deltakosh commented 6 years ago

Can you check on the repo as well if all the files are required ? i saw file with 123456.js in dist that looks suspicious Also there is a dist folder in the example folder

sebavan commented 6 years ago

great job with that !!!

antpowell commented 6 years ago

The 12345.js is the worker and the naming is how parcel bundled it but I can fix that, and same for the dist in the example I use parcel to run the server for testing and it creates a dist by default.

deltakosh commented 6 years ago

yes we need more meaningful naming ;)