BabylonJS / Extensions

Extensions for Babylon.js
175 stars 154 forks source link

htmlmesh - relax babylonjs/core version dependency #295

Closed yedpodtrzitko closed 1 week ago

yedpodtrzitko commented 3 weeks ago

Hi the peerDependency of @babylonjs/core in HtmlMesh is currently bound to version 6.x, so when using it in project with Babylon v7, I'm getting this error:

$ npm update
npm error code ERESOLVE
npm error ERESOLVE unable to resolve dependency tree
npm error
npm error While resolving: babylonjs-typescript-webpack-template@0.0.1
npm error Found: @babylonjs/core@7.10.2
npm error node_modules/@babylonjs/core
npm error   @babylonjs/core@"^7.0.0" from the root project
npm error
npm error Could not resolve dependency:
npm error peer @babylonjs/core@"^6.30.0" from babylon-htmlmesh@1.2.0
npm error node_modules/babylon-htmlmesh
npm error   babylon-htmlmesh@"^1.2.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

I can override the issue as advised, but it seems there's no reason to keep the dependency pinned in as it is (?)

ckeiner commented 2 weeks ago

Any updates on this? My Babylon 7 project is unfortunately blocked by the same issue and I'd like to avoid relying on --force to install dependencies, so it'd be great if this was solved.