search

Baccata / vscode-scaladex-search

An humble plugin to search for scala libraries
Apache License 2.0
38 stars 4 forks source link

Libs published only for Scala 3 are not found #11

Closed carlosedp closed 1 year ago

carlosedp commented 1 year ago

Due to the filtering here, Scala libs published only for Scala 3 like one I publish are not found.

Baccata commented 1 year ago

What would be your preferred solution ?

We could have a vscode setting for preferred Scala version. I'm not sure I want to add another prompt for the version ...

carlosedp commented 1 year ago

I thought maybe querying scaladex twice, one for 2.13 and another for 3... then merging and deduping the json results.

This way it would avoid the user from defining parameters. Since choosing the lib via the extension already doesn't guarantees that the lib and version selected is compatible with the current project, this wouldn't make too much of a difference.

What do you think?

carlosedp commented 1 year ago

I've pushed #12 but be welcome to change it if desired :)

carlosedp commented 1 year ago

Weird... in the dev version it finds my scala 3 only lib... but in the latest 0.3.4 that is published, it doesn't:

image

image

In the dev version locally (from main branch):

image

Baccata commented 1 year ago

I'll give it a look

Baccata commented 1 year ago

So, interestingly I had the same behaviour as you've experienced. I went to the extension window in vscode, and there was a "reload required" button appearing next to the scaladex search extension. I clicked, it restared the editor, and I'm now seeing your library.

carlosedp commented 1 year ago

Weird... I closed all vscode windows, reopened and had the same result.

I'm currently traveling on vacations so can't test it but will report in some days :)

carlosedp commented 1 year ago

Hey, back...

I tried again... tried removing the extension and re-adding but it still doesn't find the lib.

Even tried creating a new profile with only the scaladex and metals extensions but same results... no lib show.

Baccata commented 1 year ago

not sure what to tell you, except that it works on my machine 😞. I've uninstalled the extension, reloaded my editor, and re-installed it and it works :/

Screenshot 2023-09-14 at 11 56 26 Screenshot 2023-09-14 at 11 56 37
Baccata commented 1 year ago

@carlosedp, no luck ?

carlosedp commented 1 year ago

Weirdly enough... on my daily VSCode (Mac), doesn't work. I've installed the VSCode Insiders, synched to my account to get the extensions and it worked fine... also in my other computer, a Windows 11 PC with all extensions it worked as well...

Who knows! I think i'll close this since it's not the extension but my system. Thanks!

carlosedp commented 1 year ago

BTW, I just tried removing everything and reinstalling VSCode (I forgot a temp dir when I tried a while back) and it worked...

Thanks and sorry about the noise :)

Baccata commented 1 year ago

Np, glad it got sorted 👍