Bachmann1234 / java9_kernel

An ipython kernel for java 9
Apache License 2.0
72 stars 17 forks source link

Enhancement-Request: Output repeats input #2

Open nneubauer opened 9 years ago

nneubauer commented 9 years ago

The output inside a jupyter notebook resembles the output of the repl imo too closely. Specifially it repeats all inputs (probably because each line break is sent to the repl independently).

In [6]:

String a = "b";
String b = "c";
String d = "e";

yields:

 String a = "b";
|  Modified variable a of type String with initial value "b"

 String b = "c";
|  Modified variable b of type String with initial value "c"

 String d = "e";
|  Added variable d of type String with initial value "e"

Suggestion: Maybe removing all line breaks might help, as the output in the repl looks better when doing so:

-> String a = "b"; String b = "c"; String c = "d";
|  Modified variable a of type String with initial value "b"
|  Modified variable b of type String with initial value "c"
|  Added variable c of type String with initial value "d"
Bachmann1234 commented 9 years ago

So you can make this slightly better by sending the command /v concise

But yeah, I don't love the repeated input either. I played around with trying to remove the lines but it struck me as fragile and error prone so I left it alone.

I suspect to get nicer behavior I would need to go ahead and write a proper kernel without relying on the repl wrapper.