search

Bachmann1234 / java9_kernel

An ipython kernel for java 9
Apache License 2.0
72 stars 17 forks source link

Docker #21

Closed moisei closed 8 years ago

moisei commented 8 years ago

Functioning docker container for java9 notebook

Bachmann1234 commented 8 years ago

This is very exciting! I will try it out sometime today and likely merge.

Thanks!

Bachmann1234 commented 8 years ago

Looks pretty good. One minor issue. Im seeing a lot of references to jovyancan you replace these with something generic like java9kernel or something else?

moisei commented 8 years ago

It is not minor, unfortunately, the parent notebook container is built this way. This is why I am calling it "proof of concept". Whoever would need a java notebook, can reuse this code in their environment.

moisei commented 8 years ago

I've just found a problem with kulla.jar - it doesn't persist on the build server". I will submit a fix soon

moisei commented 8 years ago

fixed.

Bachmann1234 commented 8 years ago

Cool! Thanks!

Bachmann1234 commented 8 years ago

@moisei just a heads up, I merged your PR but did another commit to remove the provided jar. I am not allowed to distribute that jar from here without violating the licensing for that jar. I updated the readme to provide a link.

moisei commented 8 years ago

@Bachmann1234 good catch on license, thanks. May I ask you where did you see that license, so I know to check it next time?

Bachmann1234 commented 8 years ago

Im fairly confident the binary is covered by http://openjdk.java.net/legal/binary-license-2007-08-02.html