Bachmann1234 / java9_kernel

An ipython kernel for java 9
Apache License 2.0
72 stars 17 forks source link

Fix typos and add env vars to kernel.json #5

Closed dsblank closed 8 years ago

dsblank commented 8 years ago

Adding env vars makes it a little easier to manage, because the setup is all in one file.

Bachmann1234 commented 8 years ago

Thanks for the polish!

dsblank commented 8 years ago

You're welcome! Thanks for showing how this can be done. Expectations met :)

BTW, in #3 with just a few line changes, you can (optionally) run with a full suite of "magics" (metacommands) such as %download, %lsmagics, %macro, %include, etc.

Shall I send a PR?

Bachmann1234 commented 8 years ago

Lets talk about that in the issue (I responded there just this morning). I just want to understand a bit more about what this is.