move processAudiencesSegmentation after setupUsers in the LegalEntity…

[madz0]

move processAudiencesSegmentation after setupUsers in the LegalEntitySaga

Description

move processAudiencesSegmentation after setupUsers in the LegalEntitySaga as when you run it after processJobProfiles some users might be filtered out because of lacking referenceJobRole. Because of this code inside LegalEntitySaga:

private Mono<List<BusinessFunctionGroup>> getBusinessFunctionGroupTemplates(LegalEntityTask streamTask, JobProfileUser jobProfileUser) {
    streamTask.info(LEGAL_ENTITY, BUSINESS_FUNCTION_GROUP, "getBusinessFunctionGroupTemplates", "", "", "Using Reference Job Roles and Custom Job Roles defined in Job Profile User");
    List<BusinessFunctionGroup> businessFunctionGroups = jobProfileUser.getBusinessFunctionGroups();
    if (!isEmpty(jobProfileUser.getReferenceJobRoleNames())) {
        return accessGroupService.getFunctionGroupsForServiceAgreement(retrieveServiceAgreement(streamTask.getData()).getInternalId())
            .map(functionGroups -> {
                Map<String, FunctionGroupItem> idByFunctionGroupName = functionGroups
                    .stream()
                    .filter(fg -> nonNull(fg.getId()))
                    .collect(Collectors.toMap(FunctionGroupItem::getName, Function.identity()));
                return jobProfileUser.getReferenceJobRoleNames().stream()
                    .map(idByFunctionGroupName::get)
                    .filter(Objects::nonNull)
                    .map(businessFunctionGroupMapper::map)
                    .collect(Collectors.toList());
            })
            .map(bf -> {
                if (!isEmpty(businessFunctionGroups))
                    bf.addAll(businessFunctionGroups);
                return bf;
            });
    }
    return Mono.justOrEmpty(businessFunctionGroups);
}

Checklist

• [x] I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
• [x] I made sure to update CHANGELOG.md.
• [x] I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
• [x] My changes are adequately tested.
• [x] I made sure all the SonarCloud Quality Gate are passed.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication