BEFOUND-1451: replaced ssdk core starter with reactive dependency

Backbase / stream-services

Stream Services are an Open-Source accelerator to connect with Backbase "out-of-the-box" components responsible for orchestrating calls to Banking Services.

http://engineering.backbase.com/stream-services/

Other

28 stars 21 forks source link

BEFOUND-1451: replaced ssdk core starter with reactive dependency #431

Closed mina-ats closed 4 months ago

mina-ats commented 4 months ago

Description

A few sentences describing the overall goals of the pull request's commits. service-sdk-starter-reactive is depreacted and will be removed soon so the best replacement is service-sdk-starter-core.

Checklist

[x] I made sure, I read CONTRIBUTING.md to put right branch prefix as per my need.
[x] I made sure to update CHANGELOG.md.
[ ] I made sure to update Stream Wiki(only valid in case of new stream module or architecture changes).
[x] My changes are adequately tested.
[ ] I made sure all the SonarCloud Quality Gate are passed.

mina-ats commented 4 months ago

we can not move forward like this, this has an imense impact at runtime since instead of using webflux and the reactor you changed entirely to rely on servlet-base with tomcat, this would have impact not only in funcionality but also performance as the runtime would not be non-blocking anymore

No I didn't, the ssd-starter-reactive doesn't contain webflux and things needed to reactive programming. I think the name is misleading. we have service-sdk-web-client and also spring-boot-starter-webflux in the stream-services.