search

BackburnerJS / backburner.js

A rewrite of the Ember.js run loop as a generic microlibrary
MIT License
391 stars 80 forks source link

fixing how targetQueue cleared #233

Closed bekzod closed 7 years ago

bekzod commented 7 years ago

targetQueue elements contain method index pairs not method so is was cleared wrongly this fixes it

stefanpenner commented 7 years ago

@bekzod awesome, but we should likely add a test ensuring we don't regress again.

bekzod commented 7 years ago

I think it was to big of a word to say fixing how targetQueue cleared it is just iterating through targetQueue array with i += 2 instead of i++ so checks only methods instead of indexes, so it just in sense made it more efficient instead of fixing it :P so no test need for this I think

stefanpenner commented 7 years ago

rebase, and we can merge.

Good catch!

bekzod commented 7 years ago

rebased