BackburnerJS / backburner.js

A rewrite of the Ember.js run loop as a generic microlibrary
MIT License
392 stars 80 forks source link

avoid using outer-scope `index` variable #271

Closed bekzod closed 6 years ago

bekzod commented 6 years ago

~ avoid parsing arguments before finding throttled function~ ~ other small things~ avoid using outer-scope index variable

rwjblue commented 6 years ago

Looks like the other PR's caused some conflicts here.

bekzod commented 6 years ago

@rwjblue resolved :)

bekzod commented 6 years ago

@stefanpenner would be nice to merge this too, when resolving conflicts I found another issue that has been forgotten to be changed in #273 which is this https://github.com/BackburnerJS/backburner.js/pull/271/files#diff-c53a1b9353d0f3d5116eb42daba2df91R34 for each loop should iterate with 4 not 3

bekzod commented 6 years ago

made separate PR for regression #275

bekzod commented 6 years ago

@rwjblue done