search

BackburnerJS / backburner.js

A rewrite of the Ember.js run loop as a generic microlibrary
MIT License
391 stars 80 forks source link

Rethrow error in join #276

Closed kbullaughey closed 6 years ago

kbullaughey commented 6 years ago

Fixes #274. It seems undesirable to swallow an error merely as a result of registering an error handler as this changes the logic of promise chains that involve the runloop in a way that is contingent on an error handler, which generally seem used for passing logging.

rwjblue commented 6 years ago

I believe https://github.com/BackburnerJS/backburner.js/pull/277 is the correct fix, would you mind reviewing?

kbullaughey commented 6 years ago

I Agree.