BackofenLab / GraphClust-2

A pipeline for structural clustering of RNA secondary structures
GNU General Public License v3.0
14 stars 4 forks source link

Docker daily builds and latest tag #28

Closed mmiladi closed 7 years ago

mmiladi commented 7 years ago

Because of some broken pipeline runs, It would be better to assign docker latest tag to latest released github version, not to the master branch. In this case it is also crucial to stop daily rebuilding of released stable docker container. @bgruening Which entity triggers the daily builds of the tags? How can I stop the daily automatic rebuilds :-D?

bgruening commented 7 years ago

The base image is pinned: https://github.com/BackofenLab/docker-galaxy-graphclust/blob/master/Dockerfile#L3 I removed the automatic link to the galaxy-stable image, which gets rebuild every 24h, to get latest updates and bugfixes - imho we should keep this.

The interesting question is what broke and why? ;)

mmiladi commented 7 years ago

Where is this automatic link to the galaxy-stable image :-D?

The main reason is there are many entities (conda builds, toolshed wrappers) not in control of this repository. So I would prefer to have the released latest versions tested ;-)

mmiladi commented 7 years ago

@bgruening The workflow currently fails to open: Error is Following tools missing: [u'toolshed.g2.bx.psu.edu/repos/bgruening/infernal/infernal_cmbuild/1.1.0.2']

bgruening commented 7 years ago

We can pin TS revisions to prevent this. But in general you can simply tag git releases and then you get a Docker pinned image. This can also point to latest.

mmiladi commented 7 years ago

Good idea, we tag latest release with 'latest' and master branch with 'development'

I removed the automatic link to the galaxy-stable image,

This I don't get. The dockerfile is not changed, where was the automatic link?

bgruening commented 7 years ago

Let's discuss this tomorrow and I will show you how to do this.

mmiladi commented 7 years ago

:+1: