logkeys depends on non-standard C extension

[GoogleCodeExporter]

What steps will reproduce the problem?
1.Try to compile with an older (and yet modern) version of gcc (4.1.2) (or any 
version older than 4.3)
2.
3.

What is the expected output?
 A clean build
What do you see instead?

$ make
make  all-recursive
make[1]: Entering directory `/tmp/logkeys-0.1.1a/build'
Making all in src
make[2]: Entering directory `/tmp/logkeys-0.1.1a/build/src'
g++ -DHAVE_CONFIG_H -I. -I../../src -I..     -Wall -O3 
-DSYS_CONF_DIR=\"/usr/local/etc\" -MT logkeys.o -MD -MP -MF .deps/logkeys.Tpo 
-c -o logkeys.o ../../src/logkeys.cc
In file included from ../../src/logkeys.cc:59:
../../src/args.cc:49:34: error: invalid suffix "b1" on integer constant
../../src/args.cc:50:33: error: invalid suffix "b10" on integer constant
../../src/args.cc:51:34: error: invalid suffix "b100" on integer constant
../../src/args.cc:52:30: error: invalid suffix "b1000" on integer constant
../../src/args.cc:53:29: error: invalid suffix "b10000" on integer constant
../../src/args.cc:54:30: error: invalid suffix "b100000" on integer constant
../../src/args.cc:76:16: error: invalid suffix "b1" on integer constant
../../src/args.cc:78:16: error: invalid suffix "b1000" on integer constant
../../src/args.cc:84:16: error: invalid suffix "b10000" on integer constant
../../src/args.cc:98:16: error: invalid suffix "b100000" on integer constant
../../src/logkeys.cc:370:37: error: invalid suffix "b1" on integer constant
../../src/logkeys.cc:384:51: error: invalid suffix "b1" on integer constant
../../src/logkeys.cc:388:61: error: invalid suffix "b1" on integer constant
../../src/logkeys.cc:393:23: error: invalid suffix "b1" on integer constant
../../src/logkeys.cc:459:20: error: invalid suffix "b100" on integer constant
../../src/logkeys.cc:523:27: error: invalid suffix "b10" on integer constant
../../src/logkeys.cc:537:26: error: invalid suffix "b100" on integer constant
../../src/logkeys.cc:577:28: error: invalid suffix "b10" on integer constant
make[2]: *** [logkeys.o] Error 1
make[2]: Leaving directory `/tmp/logkeys-0.1.1a/build/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/tmp/logkeys-0.1.1a/build'
make: *** [all] Error 2

What version of the product are you using (`logkeys --help`)?
On what operating system?
Fedora Core 7

Please provide any additional information below.
If applicable, also attach contents of /proc/bus/input/devices, the output
of command `dumpkeys -n > dumpkeys.output`, and any
other relevant files.

I suggest rewriting to exclude non-standard extensions (or at least making the 
compiler version be a dependency that configure checks for).

Original issue reported on code.google.com by jeff.fro...@gmail.com on 17 Jan 2011 at 5:42

• Merged into: #31

[GoogleCodeExporter]

Hi,

Thanks for the report.
As you can see 
(http://code.google.com/p/logkeys/source/browse/trunk/src/args.cc#30), the 
issue had already been corrected in some earlier revision and is now in waiting 
for next release.

Original comment by kernc...@gmail.com on 18 Jan 2011 at 2:14

• Changed state: Duplicate