BackupGGCode / open-source-spin-compiler

A C/C++-based port of the Parallax Propeller Spin/PASM Compiler
0 stars 0 forks source link

forum: s2_test #18

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
http://forums.parallax.com/showthread.php?137452-Open-source-Spin-PASM-compiler-
in-C-C&p=1075847&viewfull=1#post1075847

I had a quick look and it turns out it's another un/signed issue. 

Access to ->obj[idx] in the attached file is done with a signed short for the 
index which is potentially treated as a negative offset (0x8xxx). I fixed all 
locations in the file and the resulting binary is a perfect match to what the 
PropTool generates. That said there may be other places where this becomes an 
issue.

Original issue reported on code.google.com by marko.lu...@kyi.biglobe.ne.jp on 21 Feb 2012 at 12:51

Attachments:

GoogleCodeExporter commented 9 years ago
File changes have been done against rev 31.

Original comment by marko.lu...@kyi.biglobe.ne.jp on 21 Feb 2012 at 12:51

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thanks Marko, I will apply these changes and get them checked in soon.

Original comment by reltham on 22 Feb 2012 at 2:01

GoogleCodeExporter commented 9 years ago
This is fixed in r32.

Original comment by reltham on 26 Feb 2012 at 7:06