BackupGGCode / wl500g

ASUS WL-5xx RT-N1x Oleg's based custom firmware
0 stars 0 forks source link

Tables displayed incorrectly in Chrome #237

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
All tables displayed incorrectly in Chrome. For example, table that contains 
port forwarding.

Code that doesn't work:
<select size="8" name="VSList_s" multiple="true" style="font-family: 
'fixedsys'; font-size: '8pt'">

Code that works perfectly:
<select size="8" name="VSList_s" multiple="true" style="font-family: monospace; 
font-size: 8pt; width: 100%;">

Original issue reported on code.google.com by burning....@gmail.com on 20 Jun 2011 at 10:35

GoogleCodeExporter commented 9 years ago

Original comment by lly.dev on 15 Sep 2011 at 7:15

GoogleCodeExporter commented 9 years ago
Please try r3297

Original comment by lly.dev on 16 Sep 2011 at 7:02

GoogleCodeExporter commented 9 years ago
It wasn't fixed completely. Chrome ignores bad CSS inside style attribute. All 
CSS values are enclosed by single quotes, which is not allowed.

Example:
style="font-family: 'fixedsys'; font-size: '8pt'"

Must be changed to:
style="font-family: fixedsys; font-size: 8pt"

Original comment by burning....@gmail.com on 16 Sep 2011 at 9:58

GoogleCodeExporter commented 9 years ago
Ok, thanks. If you can prepare patch, it will speedup fixes.

Original comment by lly.dev on 16 Sep 2011 at 10:26

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Ok, I will try now.

Original comment by burning....@gmail.com on 16 Sep 2011 at 10:29

GoogleCodeExporter commented 9 years ago
In case of you use SVN:
 1) Fix files under www/
 2) Produce patch by "svn diff >www.patch"

Otherwise, you must have two directories - www.orig/ (Not modified files) & 
www/ (Fixed one). So, use "diff -urNBp www.orig/ www/ >www.patch"

Original comment by lly.dev on 16 Sep 2011 at 10:39

GoogleCodeExporter commented 9 years ago
That's what I've done:

1. Fixed all occurencies were single quotes was used instead of double quotes 
for style attribute parameters.
2. Removed single quotes from CSS inside style attribute.
3. Fixed index.js to produce a bit more standards-compliant HTML code.

Original comment by burning....@gmail.com on 16 Sep 2011 at 12:21

Attachments:

GoogleCodeExporter commented 9 years ago
1. Why? It must be acceptable by any browser - 
http://www.w3.org/TR/html4/intro/sgmltut.html#h-3.2.2

2. Ok

3. Same as p.p.1 - could you provide link to proposal?

Original comment by lly.dev on 16 Sep 2011 at 12:31

GoogleCodeExporter commented 9 years ago
My mistake, I believed it was recommended to use double quotes for attribte 
parameters, but it appears I was wrong. Should I make another patch without 
these changes?

Original comment by burning....@gmail.com on 16 Sep 2011 at 12:52

GoogleCodeExporter commented 9 years ago
Unfortunately, none of us are "guru" in html-standards. So, we simply have to 
trust to public available documents.

Yes, if it possible, please prepare new patch. After rssdev10 approve it, I'll 
apply it into SVN.

Original comment by lly.dev on 16 Sep 2011 at 12:57

GoogleCodeExporter commented 9 years ago
Ok, this patch adds monospace font family after fixedsys for compatibility and 
removes quotes from font-size CSS property, which was breaking standards. Also 
fixes one error in index.js (missing space between two attributes).

Original comment by burning....@gmail.com on 16 Sep 2011 at 2:33

Attachments:

GoogleCodeExporter commented 9 years ago
Thank you, but unfortunately your patch made for previous revision. Now I 
carried out a style attribute into the style.css. Please test it for 
compatibility.

Original comment by rssdev10@gmail.com on 16 Sep 2011 at 7:23

Attachments:

GoogleCodeExporter commented 9 years ago
I looked at your patch and it's even better. Cannot test it now, but I'm sure 
it's fine.

Original comment by burning....@gmail.com on 16 Sep 2011 at 7:28

GoogleCodeExporter commented 9 years ago
Fixed after r3312

Original comment by lly.dev on 21 Sep 2011 at 9:03