Backupiseasy / ThreatPlates

Nameplate addon for World of Warcraft
https://wow.curseforge.com/projects/tidy-plates-threat-plates
37 stars 22 forks source link

Nameplate Mouseover Area Misalignment #465

Open dmcurtis1 opened 1 year ago

dmcurtis1 commented 1 year ago

The bounding box for nameplate mouseover is skewed to the right and doesn't line up with the "Clickable Area" setting. This issue persists even without any other addons enabled. https://github.com/Backupiseasy/ThreatPlates/assets/63743560/fa5fb989-5da8-4a88-b0a7-f7ab6a8aad6a

Backupiseasy commented 1 year ago

That is interessting. The clickable area is - to my knowledge - always centered on the character. Even if the configuration area is wrong, the actual clickable area should never be off-center. To my knowledge, addons can only change the height/width of the clickable area - or more like the Blizzard nameplate which is hidden - but not change it's positioning.

No idea why that should happen or how that is even possible. I will investigate, but I am not optimistic.

Backupiseasy commented 1 year ago

Is this Classic?

dmcurtis1 commented 1 year ago

This is WotLK Classic. For the record I've witnessed the same behavior with both ThreatPlates and Plater. I can temporarily provoke the nameplate mouseover area to function normally with this sequence:

  1. Navigate to: (/tptp, Blizzard Settings, "Names" tab) -->Check "Names Only" box, wait for automatic reload to complete

  2. Navigate to: (/tptp, Visibility) -->Check "Show Blizzard Nameplates for Friendly Units" -->Check "Show Blizzard Nameplates for Neutral and Enemy Units"

  3. Navigate back to: (/tptp, Blizzard Settings, "Names" tab) -->Uncheck "Names Only" box, wait for automatic reload to complete

  4. Navigate back to: (/tptp, Visibility) -->Uncheck "Show Blizzard Nameplates for Friendly Units" -->Uncheck "Show Blizzard Nameplates for Neutral and Enemy Units"

For whatever reason, this sequence causes my Nameplate Mouseover area to now correctly obey the parameters set in the "Clickable Area" settings, and function exactly as expected. Perfect fix? Sort-of. The only problem now is that this fix doesn't persist. It has to be repeated after every loading screen, /reload, or relog.

p.s. Don't ask me how I figured out that sequence fixed things. I've been pulling my hair out for months trying to figure this bug out lmao

dmcurtis1 commented 1 year ago

Any leads on this issue?

Backupiseasy commented 1 year ago

No, not yet. I (seem to) remember that I had a situation like that when testing changing the clickable area in Classic. That's why I asked if this is classic. But I cannot remember what I did back then :(

drixlow commented 1 year ago

I've been having this same issue for a long time now as well (WotLK classic), thought I was going crazy. I currently use plater but I see this impacts ThreatPlates as well. Please let me know if I can provide any additional info to assist in fixing this.

https://github.com/Backupiseasy/ThreatPlates/assets/83472877/d6754a96-df87-48a5-b91c-a00b0a8b1c15

Backupiseasy commented 1 year ago

Can you both test something for me? If I change the clickable area, it looks like this:

image

As you can see, although healthbar and nameplate are not aligned, the healthbar is centered on the character. For you, it should look different, more like this:

image (Ignore the bad graphics editing!)

You can test that by disabling Threat Plates for friendly and/or enemy units in General - Visibility.

If you want to see if the off-center alignment increases with a wider nameplate, you can use this command:

/script C_NamePlate.SetNamePlateFriendlySize(300, 64)

How does the Blizzard nameplate (like above) look for you when the clickable area is off-center?

Also, as you mentioned that this happens with Plater and Threat Plates, does this also happen when you disable these addons and use default Blizzard plates? How does ist look? Is the visible nameplate/healthbar centered, but the clickable area is not?

drixlow commented 1 year ago

Default Nameplates (not targeted): default_notarget

Default Nameplates (targeted): default_target

Threat Plates (not targeted): tp_notarget

Threat Plates (targeted): tp_target

Threat Plates (not targeted): tp_large_notarget

Threat Plates (targeted): tp_large_target

Hopefully this can help visualize the situation. I followed your instruction and widened the nameplate to see how it impacted the clickable area. The first two images are default name plates, one with no target and one without, this repeats then for Threat Plates with the normal size plates and the widened version. I included the targeted images as there is scaling on current target nameplate sizing.

The mouse cursor in the screenshots is at the absolute end of the clickable area. The clickable area of the nameplates is perfectly fine when all the nameplate addons are disabled and default is used. I was able to replicate the temporary fix that dmcurtis1 mentioned above which you can see working in the below .GIF which I am currently using as a workaround. 2023-08-02_22_30_38_WowClassic

What I believe is happening is that the small portion of the nameplate where the level goes is improperly extending the nameplate on the right side as that's where the misalignment evidently favors. image

dmcurtis1 commented 10 months ago

Any updates on a solution to this bug now that the ICC patch has been live for awhile? The bug still exists in game.

dmcurtis1 commented 5 months ago

This issue is still present in the Cata prepatch. It's also present in SOD.

Backupiseasy commented 5 months ago

I am sorry. I did work on this a bit, but then gut side-tracked. I will look into it. Your explaination is good enough to understand and hopefully to fix it. Thanks for your effort.

Backupiseasy commented 5 months ago

A small update: I did some tests and re-worked how the clickable area is calulated based on the healthbar size (if synced with it). Right now, that''s only finished for Mainline, but next is doing the same for Classic.

Here's how the clickable area looks on Mainline for small and large Blizzard nameplates:

If you set the TP healthbar to the same size as the Blizzard nameplate (small: 88.5 x 4.3, large: 129.5 x 10.6), then the clickable area is the same now. The default size of TP nameplates is 120 x 10, so a bit smaller als large nameplates, so by default the clickable area is also a bit smaller. Maybe I should change that ...

Next is doing the same for Classic :D

Backupiseasy commented 5 months ago

For Classic, it now looks like this:

I uploaded a version for

for testing. With this version, the above issues should be gone. There should also be no mis-alignment anymore.

You can show the clickable area with the chat command /tptp clickable-area

Feedback is highly appreciated! :D

dmcurtis1 commented 1 month ago

The misalignment issue (the one demonstrated in the video of the original post) is still present in Cata Classic with Threat Plates v12.0.6.

dmcurtis1 commented 1 month ago

This is WotLK Classic. For the record I've witnessed the same behavior with both ThreatPlates and Plater. I can temporarily provoke the nameplate mouseover area to function normally with this sequence:

  1. Navigate to: (/tptp, Blizzard Settings, "Names" tab) -->Check "Names Only" box, wait for automatic reload to complete
  2. Navigate to: (/tptp, Visibility) -->Check "Show Blizzard Nameplates for Friendly Units" -->Check "Show Blizzard Nameplates for Neutral and Enemy Units"
  3. Navigate back to: (/tptp, Blizzard Settings, "Names" tab) -->Uncheck "Names Only" box, wait for automatic reload to complete
  4. Navigate back to: (/tptp, Visibility) -->Uncheck "Show Blizzard Nameplates for Friendly Units" -->Uncheck "Show Blizzard Nameplates for Neutral and Enemy Units"

For whatever reason, this sequence causes my Nameplate Mouseover area to now correctly obey the parameters set in the "Clickable Area" settings, and function exactly as expected. Perfect fix? Sort-of. The only problem now is that this fix doesn't persist. It has to be repeated after every loading screen, /reload, or relog.

p.s. Don't ask me how I figured out that sequence fixed things. I've been pulling my hair out for months trying to figure this bug out lmao

I can still fix it using this sequence, but that fix is still temporary and is immediately reset after every loading screen or /reload.

Backupiseasy commented 1 month ago

When this mis-alignment is active, can you use the chat command /tptp clickable-area and post a screenshot here how it looks? I cannot reproduce this currently.