Closed ishanvyas22 closed 1 year ago
Even though PHP 7.4 is EOL, I'd still keep it supported on our end. Dropping support for it should only be considered when raising the major version of BaconQRCode.
@DASPRiD Fair enough, I've update the PR. Please review.
Merging #117 (5b458e3) into master (5c2d190) will decrease coverage by
0.53%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #117 +/- ##
============================================
- Coverage 63.42% 62.88% -0.54%
- Complexity 928 934 +6
============================================
Files 47 47
Lines 2783 2727 -56
============================================
- Hits 1765 1715 -50
+ Misses 1018 1012 -6
Impacted Files | Coverage Δ | |
---|---|---|
src/Common/BitUtils.php | 77.77% <0.00%> (-22.23%) |
:arrow_down: |
src/Encoder/MaskUtil.php | 97.52% <0.00%> (-1.69%) |
:arrow_down: |
src/Common/FormatInformation.php | 89.13% <0.00%> (-0.46%) |
:arrow_down: |
src/Renderer/ImageRenderer.php | 94.33% <0.00%> (-0.21%) |
:arrow_down: |
src/Encoder/Encoder.php | 86.53% <0.00%> (-0.11%) |
:arrow_down: |
src/Renderer/Image/ImagickImageBackEnd.php | 63.15% <0.00%> (-0.07%) |
:arrow_down: |
src/Renderer/Color/Cmyk.php | 0.00% <0.00%> (ø) |
|
src/Renderer/Path/Close.php | 100.00% <0.00%> (ø) |
|
src/Renderer/Eye/SquareEye.php | 100.00% <0.00%> (ø) |
|
src/Renderer/Eye/SimpleCircleEye.php | 0.00% <0.00%> (ø) |
|
... and 6 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This PR aims to see if any changes are needed for PHP 8.2. If not it can safely be merged.
In addition to that it also removes PHP 7.4 as it is no longer maintained (EOL).