search

Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.82k stars 208 forks source link

Fix appendKanjiBytes function #127

Closed askdkc closed 5 months ago

askdkc commented 1 year ago

This fix will close #123

DASPRiD commented 1 year ago

@askdkc Please have a look at the failing tests.

askdkc commented 12 months ago

@DASPRiD

You need to update the test. Please merge this PR https://github.com/Bacon/BaconQrCode/pull/145 to this branch and run the test again.

DASPRiD commented 12 months ago

Hmmm, I'm not sure why that other PR would be needed. The input to the function should be UTF-8.

DASPRiD commented 12 months ago

Ignore what I said, I see that you did the opposite of what I thought :D

DASPRiD commented 12 months ago

Can you fix the linting errors? Then I can merge it.

askdkc commented 12 months ago

@DASPRiD

Linting Error Fix: https://github.com/Bacon/BaconQrCode/pull/146

DASPRiD commented 12 months ago

Why did you not fix the error in this PR?

askdkc commented 12 months ago

@DASPRiD

My bad. Somehow I lost write access to this PR. (Probably I did something that screwed up the forked repo.)