search

Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.82k stars 208 forks source link

Add test folder to gitattributes #128

Closed VincentLanglet closed 1 year ago

VincentLanglet commented 1 year ago

Hi @DASPRiD,

Currently when installing the library, we test folder is downloaded but not needed. This can be avoided by added the test folder to the export-ignore list in gitattributes.

DASPRiD commented 1 year ago

They are included because the Debian packaging requires it.

VincentLanglet commented 1 year ago

Hi @williamdes, I saw you contributed to this repository and saw your message here https://github.com/DASPRiD/Enum/pull/14#issuecomment-1623834663

Do you think the same magic can be done here ?

williamdes commented 1 year ago

I am not sure why @DASPRiD did close and not merge the other request. Since like I said I am the one to do the Debian packaging

VincentLanglet commented 1 year ago

Since https://github.com/DASPRiD/Enum/pull/14 is merged, can we do the same for this lib @williamdes ?

DASPRiD commented 1 year ago

@VincentLanglet I guess we can, can you re-open the PR?

VincentLanglet commented 1 year ago

Sure https://github.com/Bacon/BaconQrCode/pull/141