search

Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.88k stars 212 forks source link

feat: allow PHPUnit 10 #156

Closed Chris53897 closed 8 months ago

Chris53897 commented 8 months ago

allow "spatie/phpunit-snapshot-assertions" 5

Chris53897 commented 8 months ago

PHPUnit 11 support could be provided with a seperate configuration file with the migrated configuration. CI needs to be adjusted to read the correct file. I think it is not worth the effort right now.

DASPRiD commented 8 months ago

Is there actually any reason to not rely on PHPUnit 11 specifically and ignore all older versions? This is a dev dependency afterall.

Chris53897 commented 8 months ago

The lowest supported PHP Version is 7.1 "php": "^7.1 || ^8.0", We need to support PHPUnit 7 until the PHP Min Version is bumped. https://packagist.org/packages/phpunit/phpunit#7.5.20

DASPRiD commented 8 months ago

Ah yeah, that makes sense. I wonder if it's safe by now to drop PHP 7 (and 8.0), since those have been EOL for some time. Of course, that'd mean bumping our major version to 3.

Chris53897 commented 8 months ago

I am in favor of dropping older PHP versions. Min Version PHP ^8.1 ? https://www.php.net/supported-versions.php

Do your want to work on this, or should i?

DASPRiD commented 8 months ago

Feel free to go ahead!

Chris53897 commented 8 months ago

I am working on it