search

Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.88k stars 212 forks source link

feat: drop support for php 8 #157

Closed Chris53897 closed 8 months ago

Chris53897 commented 9 months ago

allow PHPUnit 10/11, allow "spatie/phpunit-snapshot-assertions" 5

superseeds #156 and #153

codecov-commenter commented 9 months ago

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 62.81%. Comparing base (1035f6a) to head (d502e11).

Files Patch % Lines
src/Common/BitArray.php 66.66% 1 Missing :warning:
src/Renderer/Color/Alpha.php 0.00% 1 Missing :warning:
src/Renderer/Color/Cmyk.php 0.00% 1 Missing :warning:
src/Renderer/Eye/CompositeEye.php 0.00% 1 Missing :warning:
src/Renderer/Module/DotsModule.php 0.00% 1 Missing :warning:
src/Renderer/Module/RoundnessModule.php 0.00% 1 Missing :warning:
src/Renderer/Path/Curve.php 0.00% 1 Missing :warning:
src/Renderer/Path/EllipticArc.php 0.00% 1 Missing :warning:
src/Renderer/PlainTextRenderer.php 0.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #157 +/- ## ============================================ - Coverage 62.92% 62.81% -0.12% + Complexity 935 933 -2 ============================================ Files 47 47 Lines 3086 3047 -39 ============================================ - Hits 1942 1914 -28 + Misses 1144 1133 -11 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Chris53897 commented 9 months ago

@DASPRiD ready for review

DASPRiD commented 8 months ago

LGTM!

DASPRiD commented 8 months ago

Could you squash your commits down to a single commit, so I can retain your authorship?

Chris53897 commented 8 months ago

done

Chris53897 commented 8 months ago

@DASPRiD Anything else i should do here?