Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.82k stars 208 forks source link

Fix Shift JIS support #160

Closed askdkc closed 5 months ago

askdkc commented 5 months ago

This PR is a fix for the issue #123

askdkc commented 5 months ago

@DASPRiD

I have no idea which part is causing the Lint error (no logs it seems). If you can show me where to fix, I'm happy to do that.

DASPRiD commented 5 months ago

@askdkc There are logs, it's about non-required use of double quotes instead of single quotes, click on the details.

codecov-commenter commented 5 months ago

Codecov Report

Attention: Patch coverage is 68.29268% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 63.28%. Comparing base (3c6b551) to head (ec210b9). Report is 13 commits behind head on master.

Files Patch % Lines
src/Encoder/Encoder.php 77.77% 2 Missing :warning:
src/Renderer/Image/SvgImageBackEnd.php 0.00% 2 Missing :warning:
src/Common/BitArray.php 66.66% 1 Missing :warning:
src/Renderer/Color/Alpha.php 0.00% 1 Missing :warning:
src/Renderer/Color/Cmyk.php 0.00% 1 Missing :warning:
src/Renderer/Eye/CompositeEye.php 0.00% 1 Missing :warning:
src/Renderer/Module/DotsModule.php 0.00% 1 Missing :warning:
src/Renderer/Module/RoundnessModule.php 0.00% 1 Missing :warning:
src/Renderer/Path/Curve.php 0.00% 1 Missing :warning:
src/Renderer/Path/EllipticArc.php 0.00% 1 Missing :warning:
... and 1 more

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #160 +/- ## ============================================ + Coverage 62.88% 63.28% +0.39% Complexity 934 934 ============================================ Files 47 47 Lines 2727 2974 +247 ============================================ + Hits 1715 1882 +167 - Misses 1012 1092 +80 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

askdkc commented 5 months ago

@DASPRiD

Thanks! I fixed the lint errors.

DASPRiD commented 5 months ago

Whoops, you might have to rebase against the main branch again, I'm sorry, doing some maintenance.

askdkc commented 5 months ago

@DASPRiD

OK, I will recreated my PR as #170