search

Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.88k stars 212 forks source link

Make EPS & SVG Rendering usable on international locales #177

Open bardiir opened 8 months ago

bardiir commented 8 months ago

Revisit pr#84 as pr#100 did not address nearly all instances of the rounding error. Amended the pull request with the solution presented in pr#100 adapted to all functions

codecov[bot] commented 8 months ago

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 66.51%. Comparing base (b0105c7) to head (45082c4). Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/Renderer/Image/EpsImageBackEnd.php 0.00% 13 Missing :warning:
src/Renderer/Image/SvgImageBackEnd.php 0.00% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #177 +/- ## ========================================= Coverage 66.51% 66.51% Complexity 993 993 ========================================= Files 49 49 Lines 3178 3178 ========================================= Hits 2114 2114 Misses 1064 1064 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DASPRiD commented 7 months ago

Can you have a look at the failing checks?