search

Bacon / BaconQrCode

QR Code Generator for PHP
BSD 2-Clause "Simplified" License
1.88k stars 212 forks source link

ci: Add tests for PHP 8.4 #189

Closed Chris53897 closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.59%. Comparing base (f9cc1f5) to head (a7358b3). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #189 +/- ## ========================================= Coverage 70.59% 70.59% Complexity 995 995 ========================================= Files 49 49 Lines 3183 3183 ========================================= Hits 2247 2247 Misses 936 936 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DASPRiD commented 1 month ago

Hm, this did cause some issues in the main CI tests:

https://github.com/Bacon/BaconQrCode/actions/runs/11218336744

Chris53897 commented 1 month ago

Yes. This PR did not run the PHP 8.4 check. I do not know why. The PHP 8.4 run fails because of https://github.com/Bacon/BaconQrCode/actions/runs/11218336744/job/31181897708#step:6:24

Chris53897 commented 1 month ago

I think we need to wait for https://github.com/laminas/laminas-stdlib/pull/118