search

Bacon / BaconUser

BaconUser provides simple user management
BSD 2-Clause "Simplified" License
14 stars 9 forks source link

Don't change identifier column names #18

Closed bakura10 closed 11 years ago

bakura10 commented 11 years ago

Here : https://github.com/Bacon/BaconUser/blob/master/config/doctrine/BaconUser.Entity.User.dcm.xml#L9

You are changing the column name of the primary key (from id to user_id). I'd suggest NOT to change the default name for identifier because Doctrine make assumptions about this name when using those entities in associations (and User one is often used !). As a consequence, we need to add a @JoinColumn and change the referencedColumn attribute whenever we have an association to a user, which is not intuitive and very annoying.

I had this problem in ZfcUserDoctrine too, and I'd like not to have it here. We should favor the default usage here.

bakura10 commented 11 years ago

Addressed by https://github.com/Bacon/BaconUser/pull/16

DASPRiD commented 11 years ago

Fixed by #22