C-x is reserved for Emacs

[fehmud]

Hello,

thanks for sharing this useful package.

I have noticed that Persp Mode uses the C-x prefix. According to the GNU Emacs Lisp Manual[1], minor modes should use C-c followed by any punctuation character except {, }, <, >, : or ;. By using C-x, Persp Mode may conflict with a default key binding in a future version of Emacs.

In case you can't decide which prefix to use, you could create the map only:

(define-key persp-mode-map (kbd "s") #'persp-switch)
(define-key persp-mode-map (kbd "r") #'persp-rename)
(define-key persp-mode-map (kbd "c") #'persp-kill)
(define-key persp-mode-map (kbd "a") #'persp-add-buffer)
(define-key persp-mode-map (kbd "t") #'persp-temporarily-display-buffer)
(define-key persp-mode-map (kbd "i") #'persp-import-buffers)
(define-key persp-mode-map (kbd "k") #'persp-remove-buffer)
(define-key persp-mode-map (kbd "w") #'persp-save-state-to-file)
(define-key persp-mode-map (kbd "l") #'persp-load-state-from-file)

And then let the user decide where to bind it. For example:

 (global-set-key persp-mode-map (kbd "C-c p") persp-mode-map)

Cheers.

[1] http://www.gnu.org/software/emacs/manual/html_node/elisp/Key-Binding-Conventions.html

[Bad-ptr]

Hi. Thank you for pointing this out. I didn't know about this convention.

let the user decide where to bind it.

ok. Looks like it is the best way to do it.

[Bad-ptr]

I consider it as solved now. :)