Bad-ptr / persp-mode.el

named perspectives(set of buffers/window configs) for emacs
394 stars 44 forks source link

:generated-predicate does not return result? #135

Open indigoviolet opened 1 year ago

indigoviolet commented 1 year ago

https://github.com/Bad-ptr/persp-mode.el/blob/67be9feeb02613ea97f0de9eb5b792b193f073bc/persp-mode.el#L1418-L1424

I'm an elisp noob, but here's the :generated-predicate for one of my auto perspectives:

(lambda
    (buffer &rest rest-args)
    (when
        (buffer-live-p buffer)
        (with-current-buffer buffer
            (let
                (cond-result)
                (when
                    (cl-member-if
                        #'(lambda
                              (item)
                              (setq cond-result
                                  (cond
                                      ((symbolp item)
                                          (eq item major-mode))
                                      ((persp-regexp-p item)
                                          (persp-string-match-p item
                                              (symbol-name major-mode)))
                                      (t nil))))
                        '(vterm-mode))
                    (car rest-args))))))

This predicate returns nil on vterm-mode buffers, and it seems to be because cond-result is never returned.