Type error in persp-common-buffer-filter-functions

Bad-ptr / persp-mode.el

named perspectives(set of buffers/window configs) for emacs

401 stars 44 forks source link

Type error in persp-common-buffer-filter-functions #28

Closed mz-pdm closed 8 years ago

mz-pdm commented 8 years ago

The recent commit "Fix filtering out helm buffers." introduces the call

(string-prefix-p "Helm" (buffer-local-value 'mode-name b))

However mode-name is not always string, e.g. it's a list in Org Agenda. In such a case this call signals an error. This may make under some circumstances Emacs unusable, so please fix that with high priority.

Bad-ptr commented 8 years ago

Hope this dae604c1116663bd462184868397a420676a77d9 will help.

mz-pdm commented 8 years ago

Thanks. Looks fine to me although I haven't chance to test it yet (current persp-mode still not completely working for me).