search

Bad-ptr / persp-mode.el

named perspectives(set of buffers/window configs) for emacs
401 stars 44 forks source link

Perspectives no longer automatically save on exit (in Spacemacs) #45

Closed gilbertw1 closed 7 years ago

gilbertw1 commented 8 years ago

I recently noticed that perspectives have stopped auto saving altogether in Spacemacs. After some digging I've tracked down this commit as the source of the problem.

After reverting this commit perspectives have again begun to save again properly in Spacemacs. I'm not yet sure if this is a bug that needs to be fixed in this project or spacemacs, I've created bug there as well.

Thanks!

TheBB commented 8 years ago

It's probably our (Spacemacs') problem since we don't run that hook when exiting.

Bad-ptr commented 8 years ago

Ok, actually I think now that the right way will be to save perspectives in both kill-emacs-query-functions(try to save and query user on failure, remove emacs-kill-hook on success) and emacs-kill-hook(try to save and exit ignoring errors).

Bad-ptr commented 7 years ago

Must be fixed in https://github.com/Bad-ptr/persp-mode.el/commit/633bb2d266d5fcc4d69258e34a7d57ad5fa49f26.

gilbertw1 commented 7 years ago

Awesome, thank you! Just tested it locally and it works perfectly.