Bad-ptr / persp-mode.el

named perspectives(set of buffers/window configs) for emacs
400 stars 44 forks source link

Closing a terminal frame results in wrong-type-argumetn #73

Closed aaronjensen closed 7 years ago

aaronjensen commented 7 years ago

I have a GUI frame open, I then open a terminal frame w/ emacsclient and then delete it and I get an error.

Here is the stack trace:

Debugger entered--Lisp error: (wrong-type-argument frame-live-p #<dead frame F4 0x10b8f4808>)
  frame-root-window(#<dead frame F4 0x10b8f4808>)
  (setq rwin (frame-root-window (or frame (selected-frame))))
  (or rwin (setq rwin (frame-root-window (or frame (selected-frame)))))
  (if (or rwin (setq rwin (frame-root-window (or frame (selected-frame))))) (progn (window-state-get rwin t)))
  (when (or rwin (setq rwin (frame-root-window (or frame (selected-frame))))) (window-state-get rwin t))
  (lambda (&optional frame rwin) (when (or rwin (setq rwin (frame-root-window (or frame (selected-frame))))) (window-state-get rwin t)))(#<dead frame F4 0x10b8f4808>)
  persp-frame-save-state(#<dead frame F4 0x10b8f4808> t)
  persp-delete-frame(#<dead frame F4 0x10b8f4808>)
  run-hook-with-args(persp-delete-frame #<dead frame F4 0x10b8f4808>)
  apply(run-hook-with-args (delete-frame-functions #<dead frame F4 0x10b8f4808>))
Bad-ptr commented 7 years ago

Can you try this fix https://github.com/Bad-ptr/persp-mode.el/commit/a33c91e3738996c058841ed1985c67bedd4875e1 ?

aaronjensen commented 7 years ago

Worked for me, thanks!

Bad-ptr commented 7 years ago

Must be fixed.