search

Badcreature / mad-components

Automatically exported from code.google.com/p/mad-components
0 stars 0 forks source link

Tiled layout #40

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago 
Made changes to slightly optimize performance and memory in UIForm layout, and 
added tiled layouts. They work as expected where I've used them.

The patch can be downloaded from https://gist.github.com/791fed07152ca88ce2fd

I can't tell for sure if it's mandatory to apply before the other patches I've 
posted, I think it shouldn't.

I'm not 100% happy with some things, but they'd require deeper changes and 
don't want to do so. Also, before introducing these ones, I thought of adding 
some overflow property to horizontal and vertical, but didn't it that way to 
not introduce a new variable and some extra checks.

Also, with ASC 2.0, maybe the layout could be done in some function to be 
inlined, that way code wouldn't be duplicated in parseBlock and layout.

Lastly, I removed a (xml.localName().indexOf("Horizontal")>0) condition, seems 
to be some hack or some patch for some unexpected behaviour or unintended/old 
tag? it was a problem for tileHorizontal. If the overflow attribute were added, 
the check could be added back.

BTW, I don't use FB but happened to read on the group that you are thinking of 
moving to Git... I know it's better for projects with big colaboration, but 
actually, I prefer SVN :P. Just my opinion.

Original issue reported on code.google.com by neverbi...@gmail.com on 30 Aug 2012 at 10:09

GoogleCodeExporter commented 8 years ago 
Just found a problem with an edge case, so updated the patch.

Original comment by neverbi...@gmail.com on 31 Aug 2012 at 12:25

GoogleCodeExporter commented 8 years ago

Original comment by doc.andr...@gmail.com on 3 Sep 2012 at 2:51