Update NeuralCoref - Githubissues

BaderLab / saber

Saber is a deep-learning based tool for information extraction in the biomedical domain. Pull requests are welcome! Note: this is a work in progress. Many things are broken, and the codebase is not stable.

https://baderlab.github.io/saber/

MIT License

102 stars 17 forks source link

Update NeuralCoref #128

Closed JohnGiorgi closed 5 years ago

JohnGiorgi commented 5 years ago

Updates the NeuralCoref dependency. NeuralCoref 4.0.0 has better integration with SpaCy and a simpler method of instantiation.

This pull request also switches to en_core_web_lg as the default SpaCy model and reduces the greediness of NeuralCoref. Combined these changes should improve coref performance in Saber.

Closes

Closes #127.

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 353

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at ?%

Totals
Change from base Build 320:	0.0%
Covered Lines:
Relevant Lines:	0

💛 - Coveralls

JohnGiorgi commented 5 years ago

No idea why this is not passing the unit tests. It passes locally fine, something weird is happening when it is run with TravisCI.

JohnGiorgi commented 5 years ago

Updating this on another branch.