search

BaderSZ / uhyve

A minimal hypervisor for RustyHermit
Apache License 2.0
1 stars 0 forks source link

Remove unnecessary magic numbers and verify specification conformity #2

Open BaderSZ opened 1 year ago

BaderSZ commented 1 year ago

So far, the implementation 'works'. I should go through the v1.2 VirtIO spec and confirm that everything is correct.

BaderSZ commented 5 months ago

Ever since hermit-rs' changes w/ pci_types, BAR size and type is not registered correctly.

As an initial step, this has to be corrected: https://github.com/BaderSZ/uhyve/blob/45f5778ed92aab55f243d5f6a3c261dde9559dae/src/linux/virtio.rs#L593-L597

as well as https://github.com/BaderSZ/uhyve/blob/45f5778ed92aab55f243d5f6a3c261dde9559dae/src/linux/vcpu.rs#L321-L323 and https://github.com/BaderSZ/uhyve/blob/45f5778ed92aab55f243d5f6a3c261dde9559dae/src/linux/vcpu.rs#L361-L364

(This may be involved as well, too)